Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #38015

Merged
merged 17 commits into from
Nov 26, 2016
Merged

Rollup of 7 pull requests #38015

merged 17 commits into from
Nov 26, 2016

Conversation

bluss and others added 17 commits November 23, 2016 11:39
Make the example use DoubleEndedIterator for map, like it said it would.
The `bound` argument in `std::sync::mpsc::sync:channel(bound: usize)` was not defined in the documentation.
Remove exclamation marks from the the example error descriptions:
> The description [...] should not contain newlines or sentence-ending punctuation
Also, end sentence with a period.
Fix two small issues in iterator docs

- `collect()` is a regular method, not an adaptor (does not return an Iterator). I just randomly picked `filter` as a third common adaptor to mention instead.
- Fix example in `Map`'s docs so that it uses the DoubleEndedIterator implementation
Add a tracking issue for enum_set

I totally forgot this even existed!
Define `bound` argument in std::sync::mpsc::sync_channel in the documentation

The `bound` argument in `std::sync::mpsc::sync:channel(bound: usize)` was not defined in the documentation.
Follow our own recommendations in the examples

Remove exclamation marks from the the example error descriptions:
> The description [...] should not contain newlines or sentence-ending punctuation
…eGomez

Document how lock 'guard' structures are created.
@sanxiyn
Copy link
Member Author

sanxiyn commented Nov 26, 2016

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Nov 26, 2016

📌 Commit 44b926a has been approved by sanxiyn

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Nov 26, 2016

⌛ Testing commit 44b926a with merge 7e39c0e...

bors added a commit that referenced this pull request Nov 26, 2016
Rollup of 7 pull requests

- Successful merges: #37962, #37963, #37967, #37978, #37985, #38001, #38010
- Failed merges:
@bors bors merged commit 44b926a into rust-lang:master Nov 26, 2016
@sanxiyn sanxiyn deleted the rollup branch November 28, 2016 10:07
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants